Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(data/finset): use lattice operations #3083

Closed
wants to merge 1 commit into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Jun 15, 2020

Use , , instead of , , . Rename sup/inf to supr/infi to avoid
name conflicts.


I made data.finset compile. I'd like to know if there are any objections before porting
the rest of mathlib.

Zulip thread

Use `⊔`, `⊓`, `⊥` instead of `∪`, `∩`, `∅`.
@gebner
Copy link
Member

gebner commented Jun 15, 2020

This makes finset and set inconsistent. How about unifying the two families of operations? That is, remove Union in favor of supr and remove union in favor of sup, etc., and maybe use the notation and , etc., for both?

@urkud
Copy link
Member Author

urkud commented Jun 15, 2020

In this case what should we do with

  1. Subset
  2. Ssubset
  3. Empty set
  4. Univ?

@bryangingechen bryangingechen added RFC Request for comment WIP Work in progress labels Jun 16, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 13, 2020
@urkud
Copy link
Member Author

urkud commented Oct 21, 2021

This RFC was rejected.

@urkud urkud closed this Oct 21, 2021
@urkud urkud deleted the finset-lattice2 branch October 25, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict Please `git merge origin/master` then a bot will remove this label. RFC Request for comment WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants