Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/affine_space): affine combinations for finsets #3122

Closed
wants to merge 4 commits into from

Conversation

jsm28
Copy link
Collaborator

@jsm28 jsm28 commented Jun 20, 2020

Extend the definitions of affine combinations over a fintype to the
case of sums over a finset of an arbitrary index type (which is
appropriate for use cases such as affine independence of a possibly
infinite family of points).

Also change to have only bundled versions of weighted_vsub_of_point
and weighted_vsub, following review, so avoiding duplicating parts
of linear_map API.


Extend the definitions of affine combinations over a `fintype` to the
case of sums over a `finset` of an arbitrary index type (which is
appropriate for use cases such as affine independence of a possibly
infinite family of points), with the original definitions and results
for a `fintype` (which is appropriate for more concrete use cases such
as barycentric coordinates in a triangle, where the type is `fin 3`)
then being defined using those definitions and `finset.univ`.
@jsm28 jsm28 added the awaiting-review The author would like community review of the PR label Jun 21, 2020
src/linear_algebra/affine_space.lean Outdated Show resolved Hide resolved
src/linear_algebra/affine_space.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 22, 2020
@bors
Copy link

bors bot commented Jun 22, 2020

Canceled.

@jcommelin
Copy link
Member

Hmm, seems there are still some small problems. But overall, I'm happy with how this looks.

bors d+

@bors
Copy link

bors bot commented Jun 22, 2020

✌️ jsm28 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jsm28
Copy link
Collaborator Author

jsm28 commented Jun 22, 2020

bors r+

bors bot pushed a commit that referenced this pull request Jun 22, 2020
…3122)

Extend the definitions of affine combinations over a `fintype` to the
case of sums over a `finset` of an arbitrary index type (which is
appropriate for use cases such as affine independence of a possibly
infinite family of points).

Also change to have only bundled versions of `weighted_vsub_of_point`
and `weighted_vsub`, following review, so avoiding duplicating parts
of `linear_map` API.
@bors
Copy link

bors bot commented Jun 22, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/affine_space): affine combinations for finsets [Merged by Bors] - feat(linear_algebra/affine_space): affine combinations for finsets Jun 22, 2020
@bors bors bot closed this Jun 22, 2020
@bors bors bot deleted the affine-combination-finset branch June 22, 2020 12:20
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
…eanprover-community#3122)

Extend the definitions of affine combinations over a `fintype` to the
case of sums over a `finset` of an arbitrary index type (which is
appropriate for use cases such as affine independence of a possibly
infinite family of points).

Also change to have only bundled versions of `weighted_vsub_of_point`
and `weighted_vsub`, following review, so avoiding duplicating parts
of `linear_map` API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants