[Merged by Bors] - perf(linarith): don't repeat nonneg proofs for nat-to-int casts #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertylewis
added
the
awaiting-review
again, linarith improvements find unneeded hypotheses in the trig file
|
I have absolutely no idea why this changed the behavior in the trig functions file. It should only be about nat preprocessing, and there are no nats there. |
kbuzzard
reviewed
Jun 29, 2020
|
Thanks Kevin -- I was just blindly following the linter when I fixed those, but yes, those and more can go. I've changed those here. But maybe we need a full review of that file (in another PR?). |
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2020
This performance issue showed up particularly when using `nlinarith` over `nat`s. Proofs that `(n : int) >= 0` were being repeated many times, which led to quadratic blowup in the `nlinarith` preprocessing. Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…prover-community#3226) This performance issue showed up particularly when using `nlinarith` over `nat`s. Proofs that `(n : int) >= 0` were being repeated many times, which led to quadratic blowup in the `nlinarith` preprocessing. Co-authored-by: Rob Lewis <rob.y.lewis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This performance issue showed up particularly when using
nlinarithovernats. Proofs that(n : int) >= 0were being repeated many times, which led to quadratic blowup in thenlinarithpreprocessing.