Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(tactic/interactive_expr): show let-values in tactic state widget #3228

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - fix(tactic/interactive_expr): show let-values in tactic state widget #3228

wants to merge 3 commits into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Jun 29, 2020 •
edited
Loading

Fixes the missing let-values in the tactic state widget:

let_widget

@gebner gebner added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. t-meta Tactics, attributes or user commands labels Jun 29, 2020
@gebner gebner added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jun 30, 2020
@gebner
Copy link
Member Author

gebner commented Jun 30, 2020

cc @EdAyers

robertylewis
robertylewis reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @EdAyers approves, looks good to me!

src/tactic/interactive_expr.lean Outdated Show resolved Hide resolved
@robertylewis
Copy link
Member

I'll take Ed's thumbs up as a go.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 30, 2020
bors bot pushed a commit that referenced this pull request Jun 30, 2020
@gebner @robertylewis
fix(tactic/interactive_expr): show let-values in tactic state widget (#…
1bc6eba 
…3228)

Fixes the missing let-values in the tactic state widget:

![let_widget](https://user-images.githubusercontent.com/313929/86048315-9d740d80-ba50-11ea-9a8c-09c853687343.png)



Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Jun 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(tactic/interactive_expr): show let-values in tactic state widget [Merged by Bors] - fix(tactic/interactive_expr): show let-values in tactic state widget Jun 30, 2020
@bors bors bot closed this Jun 30, 2020
@bors bors bot deleted the widget_let branch June 30, 2020 14:02
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@gebner @robertylewis @cipher1024
fix(tactic/interactive_expr): show let-values in tactic state widget (l…
842df16 
…eanprover-community#3228)

Fixes the missing let-values in the tactic state widget:

![let_widget](https://user-images.githubusercontent.com/313929/86048315-9d740d80-ba50-11ea-9a8c-09c853687343.png)



Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertylewis robertylewis robertylewis left review comments

@EdAyers EdAyers EdAyers left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gebner @robertylewis @EdAyers