Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix(library_search): fix a bug with iff lemmas where both sides match #3270

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - fix(library_search): fix a bug with iff lemmas where both sides match #3270

wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

Also add a proper failure message for library_search, using Mario's text.

@bryangingechen bryangingechen added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Jul 2, 2020
sgouezel
sgouezel reviewed Jul 2, 2020
View reviewed changes
test/library_search/basic.lean Outdated Show resolved Hide resolved
src/tactic/suggest.lean Outdated Show resolved Hide resolved
semorrison and others added 2 commits July 2, 2020 16:25
@semorrison @sgouezel
Update test/library_search/basic.lean
d12cb2d 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@semorrison @sgouezel
Update src/tactic/suggest.lean
93a0f44 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 2, 2020
bors bot pushed a commit that referenced this pull request Jul 2, 2020
@semorrison
fix(library_search): fix a bug with iff lemmas where both sides match (…
afa1920 
…#3270)

Also add a proper failure message for `library_search`, using Mario's text.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 2, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 2, 2020
@semorrison
fix(library_search): fix a bug with iff lemmas where both sides match (…
8be66ee 
…#3270)

Also add a proper failure message for `library_search`, using Mario's text.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Jul 2, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(library_search): fix a bug with iff lemmas where both sides match [Merged by Bors] - fix(library_search): fix a bug with iff lemmas where both sides match Jul 2, 2020
@bors bors bot closed this Jul 2, 2020
@bors bors bot deleted the library_search_iff_bug branch July 2, 2020 14:14
cipher1024 pushed a commit to cipher1024/mathlib that referenced this pull request Mar 15, 2022
@semorrison @cipher1024
fix(library_search): fix a bug with iff lemmas where both sides match (…
9f27326 
…leanprover-community#3270)

Also add a proper failure message for `library_search`, using Mario's text.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @robertylewis @sgouezel @bryangingechen