Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ring_theory/matrix): (finally!) adding matrices #334

Merged
merged 7 commits into from
Sep 18, 2018

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Sep 10, 2018

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

Ellen Arlt wrote code for matrices last year but it was never PR'ed. My students used it extensively over the summer when proving relationships between matrices and linear maps. Blair Shi showed that matrices over R were an R-module. I have finally got around to tidying and PR'ing their work.

@digama0 digama0 merged commit a72807f into leanprover-community:master Sep 18, 2018
@digama0 digama0 deleted the matrix branch September 18, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants