Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/multivariate/qpf): definition #3395

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/multivariate/qpf): definition #3395

wants to merge 6 commits into from

Conversation

cipher1024
Copy link
Collaborator

Part of #3317

@cipher1024 cipher1024 changed the title Qpf multivariate feat(data/multivariate/qpf): definitio Jul 14, 2020
@cipher1024 cipher1024 changed the title feat(data/multivariate/qpf): definitio feat(data/multivariate/qpf): definition Jul 14, 2020
@cipher1024 cipher1024 mentioned this pull request Jul 14, 2020
Closed
@robertylewis robertylewis added the awaiting-review The author would like community review of the PR label Jul 14, 2020
cipher1024 and others added 3 commits July 15, 2020 09:39
@avigad avigad added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 20, 2020
robertylewis
robertylewis reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've marked a few nonterminal simp calls.

@avigad to approve a PR you now have to leave a comment with bors merge on a new line, rather than adding the green label. The label will get added automatically when you comment.

src/data/pfunctor/multivariate/basic.lean Outdated
Comment on lines 174 to 177
ext, simp [supp], split; intro h,
{ apply @h (λ i x, ∃ (y : P.B a i), f i y = x),
rw liftp_iff', intros, refine ⟨_,rfl⟩ },
{ simp [liftp_iff'], cases h, subst x,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonterminal simps

src/data/qpf/multivariate/basic.lean Outdated
Comment on lines 250 to 253
simp [liftp_iff_of_is_uniform,supp_eq_of_is_uniform,mvpfunctor.liftp_iff',h'],
split; intros; subst_vars; solve_by_elim },
{ rintros α ⟨a,f⟩,
simp [liftp_preservation] at h,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nonterminal simps

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jul 20, 2020
@avigad
Copy link
Collaborator

avigad commented Jul 20, 2020

@robertylewis Thanks for the extra check (and information). Are the nonterminal simp onlys o.k. with you? If so, I'll merge.

@cipher1024
Copy link
Collaborator Author

@avigad I believe the recommended style is for simp to be at the end of subproofs or else to use only. It makes them more robust. I can't find it documented anywhere but that's what I was recommended on the other parts of this project.

@cipher1024
Copy link
Collaborator Author

I think this might be a good reference: https://leanprover-community.github.io/extras/simp.html#when-it-is-unadvisable-to-use-simp

@robertylewis
Copy link
Member

Yes, that looks right. simp followed by any tactic that cares about the shape of the goal is an antipattern, since changing the simp set in any previous import (or changing the imports) can break the proof. We've seen lots of breakage from this in the past. simp only is okay since modifying the simp set won't change it.

@robertylewis
Copy link
Member

Trusting Jeremy's approval when I write

bors merge

@bors
Copy link

bors bot commented Jul 20, 2020

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 20, 2020
@robertylewis robertylewis removed awaiting-author A reviewer has asked the author a question or requested changes ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jul 20, 2020
@robertylewis
Copy link
Member

and again,

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 20, 2020
bors bot pushed a commit that referenced this pull request Jul 20, 2020
@cipher1024
feat(data/multivariate/qpf): definition (#3395)
b66d1be 
Part of #3317
@bors
Copy link

bors bot commented Jul 20, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/multivariate/qpf): definition [Merged by Bors] - feat(data/multivariate/qpf): definition Jul 20, 2020
@bors bors bot closed this Jul 20, 2020
@bors bors bot deleted the qpf-multivariate branch July 20, 2020 18:25
@cipher1024 cipher1024 mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@robertylewis robertylewis robertylewis left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cipher1024 @avigad @robertylewis @urkud