Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(geometry): first stab on Lie groups #3529

Closed
wants to merge 54 commits into from

Conversation

Nicknamen
Copy link
Collaborator

@Nicknamen Nicknamen commented Jul 23, 2020


In this PR we define Lie groups and we prove smoothness of some standard maps associated with the product. We also introduce the abbreviation smooth for C^\infty.

@sgouezel
Copy link
Collaborator

I have shortened some proofs in the times_cont_mdiff file, I still have to look at the Lie group file per se.

Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice, thanks! I mostly have minor comments.

src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
Nicknamen and others added 3 commits July 28, 2020 11:21
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
src/algebra/group/defs.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 28, 2020
@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 30, 2020
@Nicknamen
Copy link
Collaborator Author

(Just adding random thoughts while browsing through the files):

The class Lie_group depends on two parameters, I and G, just like smooth_manifold_with_corners does. So you could extend smooth_manifold_with_corners I G instead of taking it as a class parameter.

Actually I will need to change this back as this does not work when generalizing to smooth monoids / smooth rings etc. (see the topology folder for an example). But no need to do it in this PR, I will add it to the next one

@Nicknamen Nicknamen removed the request for review from hrmacbeth July 30, 2020 14:24
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry not to have responded to your review request, it had looked to me that you were well-supplied with more expert reviewers. It looks great!

src/geometry/algebra/lie_group.lean Outdated Show resolved Hide resolved
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
@sgouezel
Copy link
Collaborator

Thanks for this (and your patience :-)
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 30, 2020
bors bot pushed a commit that referenced this pull request Jul 30, 2020
@bors
Copy link

bors bot commented Jul 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(geometry): first stab on Lie groups [Merged by Bors] - feat(geometry): first stab on Lie groups Jul 30, 2020
@bors bors bot closed this Jul 30, 2020
@bors bors bot deleted the Lie_groups branch July 30, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants