-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(geometry): first stab on Lie groups #3529
Conversation
I have shortened some proofs in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very nice, thanks! I mostly have minor comments.
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Actually I will need to change this back as this does not work when generalizing to smooth monoids / smooth rings etc. (see the topology folder for an example). But no need to do it in this PR, I will add it to the next one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry not to have responded to your review request, it had looked to me that you were well-supplied with more expert reviewers. It looks great!
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
Thanks for this (and your patience :-) |
Pull request successfully merged into master. Build succeeded: |
In this PR we define Lie groups and we prove smoothness of some standard maps associated with the product. We also introduce the abbreviation
smooth
for C^\infty.