Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - docs(algebra/module): Remove completed TODO #3690

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 5, 2020

Today, submodule does extend add_submonoid, which is I assume what this TODO was about


This was done in #3032, cc @urkud

Today, submodule _does_ extend `add_submonoid`, which is I assume what this TODO was about
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Aug 5, 2020
@eric-wieser eric-wieser requested a review from urkud August 5, 2020 09:54
@Vierkantor Vierkantor self-assigned this Aug 5, 2020
@Vierkantor
Copy link
Collaborator

I agree that the TODO has been solved.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 5, 2020
bors bot pushed a commit that referenced this pull request Aug 5, 2020
Today, submodule _does_ extend `add_submonoid`, which is I assume what this TODO was about
@bors
Copy link

bors bot commented Aug 5, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs(algebra/module): Remove completed TODO [Merged by Bors] - docs(algebra/module): Remove completed TODO Aug 5, 2020
@bors bors bot closed this Aug 5, 2020
@bors bors bot deleted the eric-wieser/remove-todo branch August 5, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants