Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat): API for test_bit and bitwise operations #3964

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(data/nat): API for test_bit and bitwise operations #3964

wants to merge 1 commit into from

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Aug 28, 2020

@TwoFX TwoFX added the awaiting-review The author would like community review of the PR label Aug 28, 2020
@TwoFX TwoFX changed the title fea(data/nat): API for test_bit and bitwise operations feat(data/nat): API for test_bit and bitwise operations Aug 28, 2020
bryangingechen
bryangingechen approved these changes Aug 29, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwbarton
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 29, 2020
@rwbarton
Copy link
Collaborator

Along the same lines, it might be useful to prove an equiv ℕ ≃ (ℕ →₀ bool) and to show that it carries land/lor/lxor to componentwise band/bor/bxor.

bors bot pushed a commit that referenced this pull request Aug 29, 2020
@TwoFX
feat(data/nat): API for test_bit and bitwise operations (#3964)
ba41f0a
@bors
Copy link

bors bot commented Aug 29, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat): API for test_bit and bitwise operations [Merged by Bors] - feat(data/nat): API for test_bit and bitwise operations Aug 29, 2020
@bors bors bot closed this Aug 29, 2020
@bors bors bot deleted the bitwise-nat branch August 29, 2020 17:36
robertylewis pushed a commit that referenced this pull request Aug 31, 2020
@TwoFX @robertylewis
feat(data/nat): API for test_bit and bitwise operations (#3964)
47f0e0d
PatrickMassot pushed a commit that referenced this pull request Sep 8, 2020
@TwoFX @PatrickMassot
feat(data/nat): API for test_bit and bitwise operations (#3964)
fb6c019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TwoFX @rwbarton @bryangingechen