-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ring_theory/unique_factorization_domain): API for coprime, coprime factor of a power is a power #3984
Conversation
I've been working on some related stuff at the branch |
src/algebra/associated.lean
Outdated
def associates_coprime (a b : associates α) : Prop := | ||
∀ (p : associates α), prime p → p ∣ a → ¬ p ∣ b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def associates_coprime (a b : associates α) : Prop := | |
∀ (p : associates α), prime p → p ∣ a → ¬ p ∣ b | |
def associates_coprime (a b : associates α) : Prop := | |
∀ (p : associates α), prime p → p ≤ a → ¬ p ≤ b |
When in Rome, do as the Romans do: you'll see that the lemmas around this all use ≤
instead of ∣
, and there is even an explicit theorem dvd_eq_le
saying that ∣ = ≤
(not the other way round!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definition has to move, but when I do I'll keep this change in mind.
src/algebra/associated.lean
Outdated
begin | ||
intros p h₁ hb ha, | ||
exact h _ h₁ ha hb | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
begin | |
intros p h₁ hb ha, | |
exact h _ h₁ ha hb | |
end | |
λ p h₁ hb ha, h p h₁ ha hb |
golf Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
Co-authored-by: Kenny Lau <kc_kennylau@yahoo.com.hk>
If you use the "Files changed" tab, you can apply the changes in one commit instead of five. |
I'll open a new one with a clean commit that should be easier to review. |
Main result is is_pow_of_coprime. I want this for a proof of the n=4 case of fermat.