Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/ring_quot): quotients of noncommutative rings #4078

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat(algebra/ring_quot): quotients of noncommutative rings #4078

wants to merge 21 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison mentioned this pull request Sep 9, 2020
Closed
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Sep 9, 2020
kckennylau
kckennylau reviewed Sep 11, 2020
View reviewed changes
src/algebra/group/hom.lean Outdated
Comment on lines 84 to 86
@[to_additive]
theorem congr_fun {f g : M →* N} (h : f = g) (x : M) : f x = g x :=
congr_arg (λ h : M →* N, h x) h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't oppose this, but I would just like to point out that this is ext_iff.1.

src/algebra/ring/basic.lean Outdated
Comment on lines 234 to 235
theorem congr_fun {f g : α →+* β} (h : f = g) (x : α) : f x = g x :=
congr_arg (λ h : α →+* β, h x) h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

src/algebra/ring_quot.lean Outdated Show resolved Hide resolved
src/algebra/ring_quot.lean Outdated Show resolved Hide resolved
@ocfnash ocfnash mentioned this pull request Sep 13, 2020
Closed
@eric-wieser eric-wieser mentioned this pull request Sep 14, 2020
Closed
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 14, 2020
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 14, 2020
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 14, 2020
@semorrison @eric-wieser
Apply suggestions from code review
741a32f 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 15, 2020
@semorrison
Copy link
Collaborator Author

Thanks, @eric-wieser, those were useful! I had to make a few fixes to get things working, but it's clearly better now.

eric-wieser
eric-wieser reviewed Sep 15, 2020
View reviewed changes
src/algebra/ring_quot.lean Outdated Show resolved Hide resolved
src/algebra/ring_quot.lean Show resolved Hide resolved
src/algebra/ring_quot.lean Outdated Show resolved Hide resolved
src/algebra/ring_quot.lean Outdated Show resolved Hide resolved
@eric-wieser
Copy link
Member

Not something for this PR, but perhaps a follow-up: can we unify this with the additive and multiplicative congruence stuff in https://github.com/leanprover-community/mathlib/blob/7c321f8/src/group_theory/congruence.lean? It seems like ring_quot.rel is not that far off a ring congruence.

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 16, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Sep 16, 2020
@bors
Copy link

bors bot commented Sep 18, 2020

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 18, 2020
@semorrison semorrison removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 19, 2020
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Sep 19, 2020
bors bot pushed a commit that referenced this pull request Sep 19, 2020
@semorrison
feat(algebra/ring_quot): quotients of noncommutative rings (#4078)
04fe4b6 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ring_quot): quotients of noncommutative rings [Merged by Bors] - feat(algebra/ring_quot): quotients of noncommutative rings Sep 19, 2020
@bors bors bot closed this Sep 19, 2020
@bors bors bot deleted the ring_quot branch September 19, 2020 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

@kckennylau kckennylau kckennylau left review comments

@ChrisHughes24 ChrisHughes24 Awaiting requested review from ChrisHughes24

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @eric-wieser @jcommelin @kckennylau