Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/basic): simp-lemmas for bit0 and bit1 mod two #4343

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/nat/basic): simp-lemmas for bit0 and bit1 mod two #4343

wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member

Co-Authored-By: Gabriel Ebner gebner@gebner.org

@jcommelin jcommelin added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Oct 1, 2020
Vierkantor
Vierkantor approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

src/data/nat/basic.lean Outdated Show resolved Hide resolved
src/data/nat/basic.lean Outdated Show resolved Hide resolved
@jcommelin @Vierkantor
Apply suggestions from code review
3d6c249 
Co-authored-by: Vierkantor <Vierkantor@users.noreply.github.com>
Vierkantor
Vierkantor approved these changes Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead and merge this. If we ever decide on the colour of this particular bike shed, you can find me :)

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 1, 2020
bors bot pushed a commit that referenced this pull request Oct 1, 2020
@jcommelin @gebner
feat(data/nat/basic): simp-lemmas for bit0 and bit1 mod two (#4343)
f10dda0 
Co-Authored-By: Gabriel Ebner <gebner@gebner.org>
@bors
Copy link

bors bot commented Oct 1, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/basic): simp-lemmas for bit0 and bit1 mod two [Merged by Bors] - feat(data/nat/basic): simp-lemmas for bit0 and bit1 mod two Oct 1, 2020
@bors bors bot closed this Oct 1, 2020
@bors bors bot deleted the bit-mod-two branch October 1, 2020 16:43
adomani pushed a commit that referenced this pull request Oct 7, 2020
@jcommelin @gebner @adomani
feat(data/nat/basic): simp-lemmas for bit0 and bit1 mod two (#4343)
9e79abf 
Co-Authored-By: Gabriel Ebner <gebner@gebner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @gebner @Vierkantor