Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/digits): add norm_digits tactic #4452

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(data/nat/digits): add norm_digits tactic #4452

wants to merge 7 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Oct 5, 2020

This adds a basic tactic for normalizing expressions of the form nat.digits a b = l. As requested on Zulip: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/simplifying.20nat.2Edigits/near/212152395

semorrison
semorrison reviewed Oct 5, 2020
View reviewed changes
src/data/nat/digits.lean Outdated Show resolved Hide resolved
@semorrison semorrison mentioned this pull request Oct 5, 2020
Closed
@digama0 @semorrison
Apply suggestions from code review
567be1d 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@lacker lacker mentioned this pull request Oct 5, 2020
Closed
1 task
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Oct 5, 2020
@digama0 digama0 mentioned this pull request Oct 6, 2020
Closed
robertylewis
robertylewis reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/data/nat/digits.lean Outdated Show resolved Hide resolved
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 6, 2020
@robertylewis
Copy link
Member

Oh, wait -- I mixed this up with a different PR, there are no tests. Could you add a few?

bors r-

@bors
Copy link

bors bot commented Oct 6, 2020

Canceled.

@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Oct 6, 2020
@lacker lacker mentioned this pull request Oct 7, 2020
Closed
1 task
@bryangingechen bryangingechen added needs-tests t-meta Tactics, attributes or user commands labels Oct 8, 2020
@bryangingechen bryangingechen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes needs-tests labels Oct 11, 2020
@bryangingechen
Copy link
Collaborator

I added some tests.

robertylewis
robertylewis reviewed Oct 11, 2020
View reviewed changes
Copy link
Member

@robertylewis robertylewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 11, 2020
bors bot pushed a commit that referenced this pull request Oct 11, 2020
@digama0 @robertylewis @bryangingechen
feat(data/nat/digits): add norm_digits tactic (#4452)
952a407 
This adds a basic tactic for normalizing expressions of the form `nat.digits a b = l`. As requested on Zulip: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/simplifying.20nat.2Edigits/near/212152395

Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@bors
Copy link

bors bot commented Oct 11, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/digits): add norm_digits tactic [Merged by Bors] - feat(data/nat/digits): add norm_digits tactic Oct 11, 2020
@bors bors bot closed this Oct 11, 2020
@bors bors bot deleted the norm_digits2 branch October 11, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@robertylewis robertylewis robertylewis left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@digama0 @robertylewis @bryangingechen @semorrison