This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - fix(solve_by_elim): handle multiple goals with different hypotheses #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
robertylewis
approved these changes
Oct 17, 2020
| @@ -55,7 +68,7 @@ As an optimisation, after we build the list of `tactic expr`s, we actually run t | |||
| that do not in fact produce metavariables with a simple `return` tactic. | |||
| -/ | |||
| meta def mk_assumption_set (no_dflt : bool) (hs : list simp_arg_type) (attr : list name) : | |||
| tactic (list (tactic expr)) := | |||
| tactic (list (tactic expr) × tactic (list expr)) := | |||
There was a problem hiding this comment.
This type is definitely tricky to digest. I guess it's okay for now, considering the documentation. If it were any more complicated, I'd suggest bundling it into a structure assumption_set or something.
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 18, 2020
…4519) Previously `solve_by_elim*` would operate on multiple goals (only succeeding if it could close all of them, and performing backtracking across goals), however it would incorrectly only use the local context from the main goal. If other goals had different sets of hypotheses, ... various bad things could happen! This PR arranges so that `solve_by_elim*` inspects the local context later, so it picks up the correct hypotheses. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Oct 20, 2020
…4519) Previously `solve_by_elim*` would operate on multiple goals (only succeeding if it could close all of them, and performing backtracking across goals), however it would incorrectly only use the local context from the main goal. If other goals had different sets of hypotheses, ... various bad things could happen! This PR arranges so that `solve_by_elim*` inspects the local context later, so it picks up the correct hypotheses. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
solve_by_elim*would operate on multiple goals (only succeeding if it could close all of them, and performing backtracking across goals), however it would incorrectly only use the local context from the main goal. If other goals had different sets of hypotheses, ... various bad things could happen!This PR arranges so that
solve_by_elim*inspects the local context later, so it picks up the correct hypotheses.