Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - lint(multiset/pi): remove unused instance #4526

Closed
wants to merge 4 commits into from

Conversation

awainverse
Copy link
Collaborator

Removes an unused instance from multiset/pi


@awainverse awainverse added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Oct 8, 2020
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 8, 2020
bors bot pushed a commit that referenced this pull request Oct 8, 2020
Removes an unused instance from `multiset/pi`
@bors
Copy link

bors bot commented Oct 8, 2020

Build failed (retrying...):

@bryangingechen
Copy link
Collaborator

Lint is failing:
bors r-

Feel free to merge after fixing!
bors d+

@bors
Copy link

bors bot commented Oct 8, 2020

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Oct 8, 2020

Canceled.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Oct 8, 2020
@bryangingechen
Copy link
Collaborator

bryangingechen commented Oct 8, 2020

I went ahead and attempted a fix and also fixed some long lines (that should be allowed too, right?).

Let's wait for this to build just to make sure.

@bryangingechen
Copy link
Collaborator

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Oct 8, 2020
bors bot pushed a commit that referenced this pull request Oct 8, 2020
Removes an unused instance from `multiset/pi`



Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@bors
Copy link

bors bot commented Oct 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title lint(multiset/pi): remove unused instance [Merged by Bors] - lint(multiset/pi): remove unused instance Oct 8, 2020
@bors bors bot closed this Oct 8, 2020
@bors bors bot deleted the lint_multiset_pi branch October 8, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. lintfix This PR only fixes linting errors ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants