[Merged by Bors] - feat(analysis/normed_space/inner_product): Cauchy-Schwarz equality case and other lemmas #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dupuisf
added
the
awaiting-review
|
Note that #4379 depends on this PR. |
PatrickMassot
added
awaiting-author
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
|
Thanks! I've also thrown in the warning about |
dupuisf
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
| @@ -118,6 +118,9 @@ scalar product. This is what we implement in this paragraph, starting from a str | |||
| Our goal here is not to develop a whole theory with all the supporting API, as this will be done | |||
| below for `inner_product_space`. Instead, we implement the bare minimum to go as directly as | |||
| possible to the construction of the norm and the proof of the triangular inequality. | |||
|
|
|||
| Warning: Do not use this `core` structure if the space you are interested in already has a norm | |||
| instance defined on it, otherwise this will create a second non-defeq norm instance! | |||
There was a problem hiding this comment.
I think the suggestion was for the warning to go on the of_core constructor itself. Of course, it's good to warn in as many places as possible.
bors bot
pushed a commit
that referenced
this pull request
Oct 11, 2020
…se and other lemmas (#4571) Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes the Cauchy-Schwarz equality case to the complex case via
is_R_or_C. It also adds a few other lemmas related to orthogonal subspaces, and fixes a few bugs.