[Merged by Bors] - feat(algebra/free_algebra): Add a ring instance #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds a ring instance to `tensor_algebra`. The approach here does not work for `exterior_algebra` and `clifford_algebra`, and produces weird errors. Those will be easier to investigate when their foundations are in mathlib.
eric-wieser
added
the
awaiting-review
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
This also adds a ring instance to `tensor_algebra`. The approach here does not work for `exterior_algebra` and `clifford_algebra`, and produces weird errors. Those will be easier to investigate when their foundations are in mathlib.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a ring instance to
tensor_algebra.The approach here does not work for
exterior_algebraandclifford_algebra, and produces weird errors.Those will be easier to investigate when their foundations are in mathlib.
This is an alternative to #4289 that appears to pass CI.