Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(ring_theory/witt_vector): move lemmas to separate file #4693

Closed
wants to merge 1 commit into from

Conversation

jcommelin
Copy link
Member

This new file has almost no module docstring.
This is on purpose, it is a refactor PR.
A follow-up PR will add a module docstring and more definitions.

Co-Authored-By: Rob Y. Lewis rob.y.lewis@gmail.com


Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, everything which got deleted, got re-added :-) I've not seen this stuff before, these look like some really elegant proofs. Well done.

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 19, 2020
bors bot pushed a commit that referenced this pull request Oct 19, 2020
This new file has almost no module docstring.
This is on purpose, it is a refactor PR.
A follow-up PR will add a module docstring and more definitions.



Co-Authored-By: Rob Y. Lewis <rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Oct 20, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(ring_theory/witt_vector): move lemmas to separate file [Merged by Bors] - refactor(ring_theory/witt_vector): move lemmas to separate file Oct 20, 2020
@bors bors bot closed this Oct 20, 2020
@bors bors bot deleted the witt-def-preps branch October 20, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants