Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(group_theory/group_action): introduce smul_comm_class #4770

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - chore(group_theory/group_action): introduce smul_comm_class #4770

wants to merge 16 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Oct 24, 2020 •
edited
Loading

Before merging this PR, I want to add (some of):

  • instance for the action of M × N on α;
  • generalize semimodule instance on linear_maps;
  • restate linear_map.mk₂ in terms of smul_comm_class this will wait for another PR

@urkud urkud added awaiting-review The author would like community review of the PR not-ready-to-merge labels Oct 24, 2020
@urkud urkud requested a review from jcommelin October 24, 2020 18:04
urkud and others added 3 commits October 24, 2020 14:46
@urkud @kbuzzard
Update src/group_theory/group_action.lean
c80ed2f 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@urkud
Fix
73aa054
@urkud
Merge branch 'mul-comm-action' of git://github.com/leanprover-communi…
9258c5d 
…ty/mathlib into mul-comm-action
@bryangingechen bryangingechen changed the title chore(group_theory/group_action): indtroduce smul_comm_class chore(group_theory/group_action): introduce smul_comm_class Oct 24, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 26, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 26, 2020
jcommelin
jcommelin reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Some minor comments.

src/group_theory/group_action.lean Outdated Show resolved Hide resolved
src/group_theory/group_action.lean Outdated Show resolved Hide resolved
src/linear_algebra/basic.lean Show resolved Hide resolved
src/linear_algebra/basic.lean Outdated Show resolved Hide resolved
src/algebra/module/linear_map.lean Outdated Show resolved Hide resolved
src/algebra/module/linear_map.lean Outdated Show resolved Hide resolved
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 30, 2020
jcommelin
jcommelin approved these changes Oct 31, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 31, 2020
bors bot pushed a commit that referenced this pull request Oct 31, 2020
@urkud
chore(group_theory/group_action): introduce smul_comm_class (#4770)
d91c878
@bors
Copy link

bors bot commented Oct 31, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/group_action): introduce smul_comm_class [Merged by Bors] - chore(group_theory/group_action): introduce smul_comm_class Oct 31, 2020
@bors bors bot closed this Oct 31, 2020
@bors bors bot deleted the mul-comm-action branch October 31, 2020 19:37
lecopivo pushed a commit to lecopivo/mathlib that referenced this pull request Oct 31, 2020
@urkud
chore(group_theory/group_action): introduce smul_comm_class (leanpr…
aff8f75 
…over-community#4770)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@kbuzzard kbuzzard kbuzzard left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @eric-wieser @jcommelin @kbuzzard