Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/tensor_product): tensoring linear maps with modules #4771

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/tensor_product): tensoring linear maps with modules #4771

wants to merge 3 commits into from

Conversation

jcommelin
Copy link
Member

@jcommelin jcommelin commented Oct 24, 2020 •
edited by github-actions bot
Loading

@jcommelin jcommelin added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Oct 24, 2020
@jcommelin jcommelin mentioned this pull request Oct 24, 2020
Closed
3 tasks
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 25, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Oct 26, 2020
@jcommelin jcommelin removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Oct 26, 2020
@kbuzzard
Copy link
Member

Very neat code, and what seems to be a thorough API for ltensor and rtensor in the commutative case.

Vierkantor
Vierkantor approved these changes Nov 2, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eric-wieser, shall we merge this and open new issues for "redefine tensor_product.map to be that bundled hom" and for "add notation f.tensor g / f ⊗ₜ g"?

@eric-wieser
Copy link
Member

Let's let @jcommelin decide

@jcommelin
Copy link
Member Author

I would prefer to postpone those issues to a later PR.

@Vierkantor Vierkantor mentioned this pull request Nov 4, 2020
Open
@Vierkantor
Copy link
Collaborator

Created a follow-up issue #4906 about the discussion above.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 4, 2020
bors bot pushed a commit that referenced this pull request Nov 4, 2020
@jcommelin
feat(linear_algebra/tensor_product): tensoring linear maps with modul…
e303a7d 
…es (#4771)
@bors
Copy link

bors bot commented Nov 4, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/tensor_product): tensoring linear maps with modules [Merged by Bors] - feat(linear_algebra/tensor_product): tensoring linear maps with modules Nov 4, 2020
@bors bors bot closed this Nov 4, 2020
@bors bors bot deleted the ltensor-rtensor branch November 4, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcommelin @kbuzzard @eric-wieser @Vierkantor