Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/sub{monoid,group}): Add closure_induction' for subtypes #4984

Closed
wants to merge 4 commits into from

Conversation

@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Nov 12, 2020
src/group_theory/subgroup.lean Outdated Show resolved Hide resolved
src/group_theory/subgroup.lean Outdated Show resolved Hide resolved
src/group_theory/submonoid/operations.lean Outdated Show resolved Hide resolved
src/group_theory/submonoid/operations.lean Outdated Show resolved Hide resolved
src/group_theory/submonoid/operations.lean Outdated Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 12, 2020
eric-wieser and others added 2 commits November 12, 2020 12:16
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
src/group_theory/submonoid/operations.lean Outdated Show resolved Hide resolved
src/group_theory/submonoid/operations.lean Outdated Show resolved Hide resolved
src/group_theory/subgroup.lean Outdated Show resolved Hide resolved
src/group_theory/subgroup.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 12, 2020
@Vierkantor
Copy link
Collaborator

Thanks 🎉

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 12, 2020
bors bot pushed a commit that referenced this pull request Nov 12, 2020
@bors
Copy link

bors bot commented Nov 12, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/sub{monoid,group}): Add closure_induction' for subtypes [Merged by Bors] - feat(group_theory/sub{monoid,group}): Add closure_induction' for subtypes Nov 12, 2020
@bors bors bot closed this Nov 12, 2020
@bors bors bot deleted the eric-wieser/closure_induction branch November 12, 2020 16:36
bors bot pushed a commit that referenced this pull request Jan 25, 2022
…ecialization to subtypes from dependent recursors (#11555)

The following recursors (the first of which was added in #4984) are more generally applicable than to subtypes alone:

* `submonoid.closure_induction'`
* `add_submonoid.closure_induction'`
* `subgroup.closure_induction'`
* `add_subgroup.closure_induction'`
* `submodule.span_induction'`

Now that these live right next to their non-dependent version, there is little need to repeat the docstring.
bors bot pushed a commit that referenced this pull request Jan 25, 2022
…ecialization to subtypes from dependent recursors (#11555)

The following recursors (the first of which was added in #4984) are more generally applicable than to subtypes alone:

* `submonoid.closure_induction'`
* `add_submonoid.closure_induction'`
* `subgroup.closure_induction'`
* `add_subgroup.closure_induction'`
* `submodule.span_induction'`

Now that these live right next to their non-dependent version, there is little need to repeat the docstring.
ericrbg pushed a commit that referenced this pull request Jan 28, 2022
…ecialization to subtypes from dependent recursors (#11555)

The following recursors (the first of which was added in #4984) are more generally applicable than to subtypes alone:

* `submonoid.closure_induction'`
* `add_submonoid.closure_induction'`
* `subgroup.closure_induction'`
* `add_subgroup.closure_induction'`
* `submodule.span_induction'`

Now that these live right next to their non-dependent version, there is little need to repeat the docstring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants