[Merged by Bors] - feat(data/fin): add_comm_monoid and simp lemmas #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New lemmas: `add_zero` `zero_add` `mul_one` `one_mul`
pechersky
added
awaiting-review
|
I guess the question is, whether these lemmas should be available in |
github-actions
bot
added
the
merge-conflict
New lemmas: `add_zero` `zero_add` `mul_one` `one_mul`
…-community/mathlib into fin-monoid-identities
github-actions
bot
removed
the
merge-conflict
pechersky
changed the title
pechersky
added
awaiting-review
|
I know there's some controversy about arithmetic operations on
This PR doesn't add to the controversy, and the simp lemmas clean up the situation slightly. (Although you could argue that cleaning things up encourages people to use the controversial operations...) I think it's fine to merge this until there's a better story about bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jan 20, 2021
Provide `add_comm_monoid` for `fin (n + 1)`, which makes proofs that have to do with `bit0`, `bit1`, and `nat.cast` and related happy. Provide the specialized lemmas as simp lemmas. Also provide various simp lemmas about multiplication, but without the associated `comm_monoid`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
add_comm_monoidforfin (n + 1), which makes proofs that have to do withbit0,bit1, andnat.castand related happy. Provide the specialized lemmas as simp lemmas. Also provide various simp lemmas about multiplication, but without the associatedcomm_monoid.I didn't make the
comm_monoidfor multiplication, partially because I don't have a direct need for it, and partially because I couldn't juggle themul_assocproof out of the modular arithmetic nor backport from thezmodfile.