Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/separable): add separable_of_X_pow_sub_C and squarefree_of_X_pow_sub_C #5052

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat(field_theory/separable): add separable_of_X_pow_sub_C and squarefree_of_X_pow_sub_C #5052

wants to merge 14 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Nov 20, 2020 •
edited by github-actions bot
Loading

I've added that X ^ n - a is separable, and so squarefree.

@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Nov 20, 2020
awainverse
awainverse reviewed Nov 20, 2020
View reviewed changes
src/field_theory/separable.lean Outdated Show resolved Hide resolved
src/field_theory/separable.lean Outdated Show resolved Hide resolved
src/field_theory/separable.lean Outdated Show resolved Hide resolved
@awainverse awainverse added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 20, 2020
riccardobrasca and others added 3 commits November 20, 2020 19:25
@riccardobrasca @awainverse
Update src/field_theory/separable.lean
b6ae625 
Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
@riccardobrasca @awainverse
Update src/field_theory/separable.lean
dd6a084 
Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
@riccardobrasca
update separable
d026be1
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 20, 2020
@riccardobrasca
Copy link
Member Author

I someone is wondering why I introduced hpred rather then doing directly rw [nat.succ_pred_eq_of_pos hpos] is because the latter does not work. There must be something about n - 1 that I don't understand.

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 23, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 23, 2020
@awainverse awainverse removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 23, 2020
@awainverse
Copy link
Collaborator

It would be good to have corollaries of squarefree_X_pow_sub_C for fields of char_zero or char_p, but that can happen in a different PR.

@riccardobrasca
Copy link
Member Author

Yes, I can do it when this one will be merged.

jcommelin
jcommelin reviewed Nov 27, 2020
View reviewed changes
src/field_theory/separable.lean Outdated Show resolved Hide resolved
src/field_theory/separable.lean Outdated Show resolved Hide resolved
src/field_theory/separable.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 27, 2020
riccardobrasca and others added 2 commits November 27, 2020 10:59
@riccardobrasca @jcommelin
Update src/field_theory/separable.lean
68aa189 
Co-authored-by: Johan Commelin <johan@commelin.net>
@riccardobrasca @jcommelin
Update src/field_theory/separable.lean
69db8ad 
Co-authored-by: Johan Commelin <johan@commelin.net>
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 27, 2020
jcommelin
jcommelin approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 27, 2020
bors bot pushed a commit that referenced this pull request Nov 27, 2020
@riccardobrasca
feat(field_theory/separable): add separable_of_X_pow_sub_C and square…
876481e 
…free_of_X_pow_sub_C (#5052)

I've added that `X ^ n - a` is separable, and so `squarefree`.
@bors
Copy link

bors bot commented Nov 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/separable): add separable_of_X_pow_sub_C and squarefree_of_X_pow_sub_C [Merged by Bors] - feat(field_theory/separable): add separable_of_X_pow_sub_C and squarefree_of_X_pow_sub_C Nov 27, 2020
@bors bors bot closed this Nov 27, 2020
@bors bors bot deleted the X_pow_sub_squarefree branch November 27, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

@awainverse awainverse awainverse left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@riccardobrasca @awainverse @bryangingechen @jcommelin