Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/equiv/basic): Add comp_swap_eq_update #5091

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore(data/equiv/basic): Add comp_swap_eq_update #5091

wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Nov 23, 2020 •
edited by github-actions bot
Loading

I can't work out how to golf function.comp_app into term mode, which is annoying as it appears in all three branches

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Nov 23, 2020
@eric-wieser eric-wieser added the WIP Work in progress label Nov 24, 2020
@eric-wieser eric-wieser mentioned this pull request Nov 24, 2020
Closed
3 tasks
@eric-wieser eric-wieser force-pushed the eric-wieser/comp_swap_eq_update branch from b1e9962 to 35ba2ef Compare November 25, 2020 11:24
@eric-wieser eric-wieser removed the WIP Work in progress label Nov 25, 2020
@eric-wieser eric-wieser added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 25, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 25, 2020
@eric-wieser eric-wieser force-pushed the eric-wieser/comp_swap_eq_update branch from 35ba2ef to 377bdda Compare November 25, 2020 21:34
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 25, 2020
@eric-wieser eric-wieser removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Nov 25, 2020
Vierkantor
Vierkantor approved these changes Nov 26, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 26, 2020
bors bot pushed a commit that referenced this pull request Nov 26, 2020
@eric-wieser
chore(data/equiv/basic): Add comp_swap_eq_update (#5091)
2d476e0
@bors
Copy link

bors bot commented Nov 26, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/equiv/basic): Add comp_swap_eq_update [Merged by Bors] - chore(data/equiv/basic): Add comp_swap_eq_update Nov 26, 2020
@bors bors bot closed this Nov 26, 2020
@bors bors bot deleted the eric-wieser/comp_swap_eq_update branch November 26, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @Vierkantor