Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/separation): Adds t2_space instances for disjoint unions (sums and sigma types). #5113

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(topology/separation): Adds t2_space instances for disjoint unions (sums and sigma types). #5113

wants to merge 6 commits into from

Conversation

adamtopaz
Copy link
Collaborator

@adamtopaz adamtopaz added the awaiting-review The author would like community review of the PR label Nov 25, 2020
@urkud urkud added the review-in-progress A reviewer is thinking about this PR offline. label Nov 26, 2020
@urkud urkud removed the review-in-progress A reviewer is thinking about this PR offline. label Nov 26, 2020
@urkud
Copy link
Member

urkud commented Nov 26, 2020

I golfed some proofs but now it needs a review from 1 more maintainer.

bryangingechen
bryangingechen approved these changes Nov 27, 2020
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
bors d+

src/topology/separation.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Nov 27, 2020

✌️ adamtopaz can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Nov 27, 2020
@adamtopaz @bryangingechen
spacing cleanup
04695bb 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@adamtopaz
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 27, 2020
@adamtopaz @urkud
feat(topology/separation): Adds t2_space instances for disjoint union…
396487f 
…s (sums and sigma types). (#5113)

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Adam Topaz <adamtopaz@users.noreply.github.com>
@bors
Copy link

bors bot commented Nov 27, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/separation): Adds t2_space instances for disjoint unions (sums and sigma types). [Merged by Bors] - feat(topology/separation): Adds t2_space instances for disjoint unions (sums and sigma types). Nov 27, 2020
@bors bors bot closed this Nov 27, 2020
@bors bors bot deleted the t2_sums branch November 27, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamtopaz @urkud @bryangingechen