[Merged by Bors] - feat(combinatorics/simple_graph/basic): introduce incidence sets, graph construction from relation #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusakov
requested review from
jalex-stark,
b-mehta,
eric-wieser,
awainverse and
kmill
agusakov
changed the title
b-mehta
reviewed
Dec 2, 2020
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
…ity/mathlib into simple_graphs3 grabbing commits from github
agusakov
added
the
awaiting-review
kmill
reviewed
Dec 2, 2020
kmill
reviewed
Dec 2, 2020
|
This looks great to me, except I note that |
kmill
reviewed
Dec 2, 2020
kmill
reviewed
Dec 2, 2020
kmill
reviewed
Dec 2, 2020
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
…ity/mathlib into simple_graphs3 implementing changes
|
I think the speed is reasonable, it only takes a few seconds at worst for proofs to work |
Keep in mind that mathlib has 40k+ theorems, so a few seconds for a proof is actually on the slower side of things. |
eric-wieser
reviewed
Dec 3, 2020
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…ity/mathlib into simple_graphs3 pulling new commits
|
Is there anything else I should do here? |
bryangingechen
approved these changes
Dec 6, 2020
|
✌️ agusakov can now approve this pull request. To approve and merge a pull request, simply reply with |
bryangingechen
added
awaiting-author
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2020
…ph construction from relation (#5191) Add incidence sets and some lemmas, including a proof of equivalence between the neighbor set of a vertex and its incidence set. Add a graph construction from a given relation. Definitions and lemmas adapted from [simple_graphs2](https://github.com/leanprover-community/mathlib/blob/simple_graphs2/src/combinatorics/simple_graph/basic.lean#L317) Co-authored-by: agusakov <39916842+agusakov@users.noreply.github.com>
|
Build failed: |
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
…ity/mathlib into simple_graphs3 fixing proofs
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 6, 2020
…ph construction from relation (#5191) Add incidence sets and some lemmas, including a proof of equivalence between the neighbor set of a vertex and its incidence set. Add a graph construction from a given relation. Definitions and lemmas adapted from [simple_graphs2](https://github.com/leanprover-community/mathlib/blob/simple_graphs2/src/combinatorics/simple_graph/basic.lean#L317) Co-authored-by: agusakov <39916842+agusakov@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add incidence sets and some lemmas, including a proof of equivalence between the neighbor set of a vertex and its incidence set. Add a graph construction from a given relation.
Definitions and lemmas adapted from simple_graphs2