Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(linear_algebra/tensor_product): Relax the ring requirement to semiring for the group instance #5305

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(linear_algebra/tensor_product): Relax the ring requirement to semiring for the group instance #5305

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 10, 2020 •
edited
Loading

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 10, 2020
@eric-wieser eric-wieser force-pushed the eric-wieser/tensor-relax-to-semiring branch from 579a1b5 to f937cee Compare December 10, 2020 14:11
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 10, 2020
@urkud
Copy link
Member

urkud commented Dec 10, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 10, 2020
bors bot pushed a commit that referenced this pull request Dec 11, 2020
@eric-wieser
chore(linear_algebra/tensor_product): Relax the ring requirement to s…
8817c3e 
…emiring for the group instance (#5305)
@bors
Copy link

bors bot commented Dec 11, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(linear_algebra/tensor_product): Relax the ring requirement to semiring for the group instance [Merged by Bors] - chore(linear_algebra/tensor_product): Relax the ring requirement to semiring for the group instance Dec 11, 2020
@bors bors bot closed this Dec 11, 2020
@bors bors bot deleted the eric-wieser/tensor-relax-to-semiring branch December 11, 2020 04:55
@eric-wieser eric-wieser mentioned this pull request Dec 11, 2020
Closed
@eric-wieser
Copy link
Member Author

Somehow I missed the important bit, #5315

bors bot pushed a commit that referenced this pull request Dec 11, 2020
@eric-wieser
chore(linear_algebra/tensor_product): Actually relax the requirements…
029b258 
… for add_comm_group (#5315)

A previous commit (#5305) changed the definition to not need these, but forgot to actually change these.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @urkud