Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ring_theory/subring) various lemmas #532

Merged
merged 1 commit into from Dec 20, 2018

Conversation

kckennylau
Copy link
Collaborator

new lemmas:

  • is_ring_hom.is_subring_set_range
  • ring.in_closure.rec_on
  • ring.closure_mono
    changed:
  • ring.exists_list_of_mem_closure

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

For reviewers: code review check list

new lemmas:
- is_ring_hom.is_subring_set_range
- ring.in_closure.rec_on
- ring.closure_mono
changed:
- ring.exists_list_of_mem_closure
@digama0 digama0 merged commit fc90e00 into leanprover-community:master Dec 20, 2018
@digama0 digama0 deleted the subring branch December 20, 2018 13:12
@kckennylau kckennylau restored the subring branch December 20, 2018 14:10
@kckennylau kckennylau deleted the subring branch December 20, 2018 14:11
cipher1024 pushed a commit that referenced this pull request Feb 8, 2019
new lemmas:
- is_ring_hom.is_subring_set_range
- ring.in_closure.rec_on
- ring.closure_mono
changed:
- ring.exists_list_of_mem_closure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants