Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/galois): Separable splitting field is Galois #5347

Closed
wants to merge 41 commits into from
Closed

[Merged by Bors] - feat(field_theory/galois): Separable splitting field is Galois #5347

wants to merge 41 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented Dec 13, 2020 •
edited by github-actions bot
Loading

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 13, 2020
@tb65536 tb65536 changed the title feat(field_theory/galois): plitting field feat(field_theory/galois): Separable splitting field is Galois Dec 13, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 14, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 15, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 16, 2020
@github-actions github-actions bot removed merge-conflict Please `git merge origin/master` then a bot will remove this label. blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Dec 17, 2020
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label Dec 17, 2020
jcommelin
jcommelin reviewed Dec 17, 2020
View reviewed changes
src/field_theory/galois.lean Show resolved Hide resolved
src/field_theory/galois.lean Outdated Show resolved Hide resolved
src/field_theory/galois.lean Outdated Show resolved Hide resolved
src/field_theory/galois.lean Show resolved Hide resolved
src/field_theory/galois.lean Show resolved Hide resolved
tb65536 and others added 5 commits December 17, 2020 11:30
@tb65536 @jcommelin
Update src/field_theory/galois.lean
adfa11f 
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536 @jcommelin
Update src/field_theory/galois.lean
42df62d 
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536 @jcommelin
Update src/field_theory/galois.lean
6a35322 
Co-authored-by: Johan Commelin <johan@commelin.net>
@tb65536
fix error
8a4048b
@tb65536
newline
feb4699
@tb65536 @jcommelin
Update src/field_theory/galois.lean
b5112fd 
Co-authored-by: Johan Commelin <johan@commelin.net>
jcommelin
jcommelin approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 19, 2020
bors bot pushed a commit that referenced this pull request Dec 19, 2020
@tb65536
feat(field_theory/galois): Separable splitting field is Galois (#5347)
1cb9727 
Proves that a splitting field of a separable polynomial is Galois by showing that it has lots of automorphisms.



Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
@bors
Copy link

bors bot commented Dec 19, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/galois): Separable splitting field is Galois [Merged by Bors] - feat(field_theory/galois): Separable splitting field is Galois Dec 19, 2020
@bors bors bot closed this Dec 19, 2020
@bors bors bot deleted the galois_splitting_field branch December 19, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tb65536 @jcommelin