Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory): add definition of solvable group #5565

Closed
wants to merge 28 commits into from

Conversation

pglutz
Copy link
Collaborator

@pglutz pglutz commented Jan 2, 2021

Defines solvable groups using the definition that a group is solvable if its nth commutator is eventually trivial. Defines the nth commutator of a group and provides some lemmas for working with it. More facts about solvable groups will come in future PRs.


@pglutz pglutz added the awaiting-review The author would like community review of the PR label Jan 2, 2021
src/group_theory/solvable.lean Outdated Show resolved Hide resolved
src/group_theory/solvable.lean Outdated Show resolved Hide resolved
src/group_theory/solvable.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin requested a review from ocfnash January 2, 2021 08:23
pglutz and others added 3 commits January 2, 2021 00:24
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
Co-authored-by: Alex J Best <alex.j.best@gmail.com>
src/group_theory/solvable.lean Outdated Show resolved Hide resolved
src/group_theory/solvable.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the following are probably worth including here:

@[simp] lemma bot_general_commutator_eq_bot (H : subgroup G) : general_commutator ⊥ H = ⊥ := sorry

@[simp] lemma general_commutator_bot_eq_bot (H : subgroup G) : general_commutator H ⊥ = ⊥ := sorry

lemma general_commutator_comm (H₁ H₂ : subgroup G) :
  general_commutator H₁ H₂ = general_commutator H₂ H₁ := sorry

lemma general_commutator_le_right (H₁ H₂ : subgroup G) [normal H₁] :
  general_commutator H₁ H₂ ≤ H₂ := sorry

lemma general_commutator_le_left (H₁ H₂ : subgroup G) [normal H₂] :
  general_commutator H₁ H₂ ≤ H₁ := sorry

lemma general_commutator_le_inf (H₁ H₂ : subgroup G) [normal H₁] [normal H₂] :
  general_commutator H₁ H₂ ≤ H₁ ⊓ H₂ := sorry

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 2, 2021
pglutz and others added 7 commits January 2, 2021 08:06
Co-authored-by: Oliver Nash <oliver.nash@gmail.com>
Co-authored-by: Oliver Nash <oliver.nash@gmail.com>
Co-authored-by: Oliver Nash <oliver.nash@gmail.com>
Co-authored-by: Oliver Nash <oliver.nash@gmail.com>
Co-authored-by: Oliver Nash <oliver.nash@gmail.com>
Co-authored-by: Oliver Nash <oliver.nash@gmail.com>
@pglutz
Copy link
Collaborator Author

pglutz commented Jan 2, 2021

I think the following are probably worth including here:

@[simp] lemma bot_general_commutator_eq_bot (H : subgroup G) : general_commutator ⊥ H = ⊥ := sorry

@[simp] lemma general_commutator_bot_eq_bot (H : subgroup G) : general_commutator H ⊥ = ⊥ := sorry

lemma general_commutator_comm (H₁ H₂ : subgroup G) :
  general_commutator H₁ H₂ = general_commutator H₂ H₁ := sorry

lemma general_commutator_le_right (H₁ H₂ : subgroup G) [normal H₁] :
  general_commutator H₁ H₂ ≤ H₂ := sorry

lemma general_commutator_le_left (H₁ H₂ : subgroup G) [normal H₂] :
  general_commutator H₁ H₂ ≤ H₁ := sorry

lemma general_commutator_le_inf (H₁ H₂ : subgroup G) [normal H₁] [normal H₂] :
  general_commutator H₁ H₂ ≤ H₁ ⊓ H₂ := sorry

@ocfnash assuming that the assumption in general_commutator_le_right was supposed to be [normal H₂] rather than [normal H₁] (and similarly for general_commutator_le_left) I've now proved all of these.

pglutz and others added 8 commits January 2, 2021 12:50
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Johan Commelin <johan@commelin.net>
@pglutz
Copy link
Collaborator Author

pglutz commented Jan 3, 2021

@ocfnash When I write the left "square with quill" bracket in VS Code, it automatically completes with an ordinary right square bracket rather than a right "square with quill" bracket and so I have to manually change the right bracket to a "square with quill" bracket each time. Do you know if there's a way around this?

@pglutz pglutz added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 3, 2021
@ocfnash
Copy link
Collaborator

ocfnash commented Jan 3, 2021

@ocfnash When I write the left "square with quill" bracket in VS Code, it automatically completes with an ordinary right square bracket rather than a right "square with quill" bracket and so I have to manually change the right bracket to a "square with quill" bracket each time. Do you know if there's a way around this?

Argh, that sounds so painful! Sorry you had to suffer this. If you're using VSCode then the shortcuts you're missing are [- and -]. See for example here.

I usually use liel and lier myself but trying now I see now that [- generates but autocompletes with ]. Yuck! I have just asked about this on Zulip. I have also opened a PR for the VSCode extension which should resolve this issue. In the meantime maybe just use liel and lier.

@pglutz
Copy link
Collaborator Author

pglutz commented Jan 3, 2021

@jcommelin Does everything look okay now? Also, sorry for the confusion about general_commutator_comm.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 6, 2021
bors bot pushed a commit that referenced this pull request Jan 6, 2021
Defines solvable groups using the definition that a group is solvable if its nth commutator is eventually trivial. Defines the nth commutator of a group and provides some lemmas for working with it. More facts about solvable groups will come in future PRs.
@bors
Copy link

bors bot commented Jan 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory): add definition of solvable group [Merged by Bors] - feat(group_theory): add definition of solvable group Jan 6, 2021
@bors bors bot closed this Jan 6, 2021
@bors bors bot deleted the solvable_groups branch January 6, 2021 11:03
pglutz added a commit that referenced this pull request Jan 6, 2021
Defines solvable groups using the definition that a group is solvable if its nth commutator is eventually trivial. Defines the nth commutator of a group and provides some lemmas for working with it. More facts about solvable groups will come in future PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants