[Merged by Bors] - feat(data/set/lattice): add lemmas set.Union_subtype and set.Union_of_singleton_coe #5691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
added
awaiting-review
|
In another zulip thread about this same lemma I suggested that instead we should add: lemma set.Union_subtype {α β : Type*} (s : set α) (f : α → set β) :
(⋃ (i : s), f i) = ⋃ (i ∈ s), f i :=
(set.bUnion_eq_Union s $ λ x _, f x).symmBut maybe we should just have both. |
…r-community/mathlib into set.bUnion_of_singleton_of_coe
|
Eric, I added the second lemma as well! |
eric-wieser
reviewed
Jan 11, 2021
eric-wieser
reviewed
Jan 11, 2021
src/data/set/lattice.lean
Outdated
Comment on lines
365
to
367
| lemma set.Union_subtype {α β : Type*} (s : set α) (f : α → set β) : | ||
| (⋃ (i : s), f i) = ⋃ (i ∈ s), f i := | ||
| (set.bUnion_eq_Union s $ λ x _, f x).symm |
There was a problem hiding this comment.
For other reviewers - is this a good simp lemma? My feeling is yes, because we have a lot of other simp lemmas about things of the form ⋃ (i ∈ s) when s is some compound expression.
eric-wieser
added
awaiting-author
moved lemma bUnion_of_singleton_of_coe and renamed it to Union_of_singleton_coe
adomani
added
awaiting-review
bryangingechen
changed the title
bryangingechen
changed the title
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
bryangingechen
added
awaiting-author
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 17, 2021
…_singleton_coe (#5691) Add one simp lemma, following a suggestion on the Zulip chat: https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/image_bUnion
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
adomani
removed
the
awaiting-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one simp lemma, following a suggestion on the Zulip chat:
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/image_bUnion