Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(algebraic_geometry/prime_spectrum): add lemma zero_locus_bUnion #5692

Closed
wants to merge 5 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jan 10, 2021

Add a simple extension of a lemma, to be able to work with bUnion, instead of only Union.


@adomani adomani added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jan 10, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@jcommelin jcommelin self-assigned this Jan 16, 2021
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 16, 2021
@adomani adomani added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 16, 2021
@jcommelin
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 16, 2021
@eric-wieser
Copy link
Member

eric-wieser commented Jan 16, 2021

Turns out this can actually just be proved with

def zero_locus_bUnion (s : set (set R)) :
  zero_locus (⋃ s' ∈ s, s' : set R) = ⋂ s' ∈ s, zero_locus s' :=
by simp only [zero_locus_Union]

since bUnion is just two nested Unions

@jcommelin
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Jan 16, 2021

Canceled.

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@jcommelin
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 16, 2021
…5692)

Add a simple extension of a lemma, to be able to work with `bUnion`, instead of only `Union`.



Co-authored-by: Johan Commelin <johan@commelin.net>
@adomani
Copy link
Collaborator Author

adomani commented Jan 16, 2021

I do not entirely understand how the proof works, but I am happy that this is going through!

Thank you very much, @eric-wieser and @jcommelin !

@eric-wieser
Copy link
Member

I do not entirely understand how the proof works,

Try using simp_rw [zero_locus_Union, zero_locus_Union] so you can see the intermediate goal state. It's just rewriting the two binders (s' : set R) (hs : s' ∈ s) separately.

@bors
Copy link

bors bot commented Jan 16, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jan 16, 2021
…5692)

Add a simple extension of a lemma, to be able to work with `bUnion`, instead of only `Union`.



Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jan 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry/prime_spectrum): add lemma zero_locus_bUnion [Merged by Bors] - feat(algebraic_geometry/prime_spectrum): add lemma zero_locus_bUnion Jan 16, 2021
@bors bors bot closed this Jan 16, 2021
@bors bors bot deleted the zero_locus_bUnion branch January 16, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants