Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/instances/nnreal): add has_sum_nat_add_iff and module docstring #5716

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(topology/instances/nnreal): add has_sum_nat_add_iff and module docstring #5716

wants to merge 3 commits into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Jan 12, 2021 •
edited by bryangingechen
Loading

@robertylewis
Copy link
Member

Thanks! Enforcement of this has been lax recently, but could you structure the module doc with ## Main declarations, ## Implementation notes, etc as in the guidelines?

@kbuzzard kbuzzard added the awaiting-review The author would like community review of the PR label Jan 13, 2021
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2021
@bryangingechen bryangingechen changed the title feat(topology/instances/nnreal): add has_sum_nat_add_iff and module d… feat(topology/instances/nnreal): add has_sum_nat_add_iff and module docstring Jan 13, 2021
@kbuzzard
Copy link
Member Author

OK we now have main definitions and main statements. Sorry for the delay, I've been doing a lot of preaching in the last couple of weeks.

bryangingechen
bryangingechen approved these changes Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some markdown nitpicks. Thanks!
bors d+

src/topology/instances/nnreal.lean Outdated Show resolved Hide resolved
src/topology/instances/nnreal.lean Outdated Show resolved Hide resolved
src/topology/instances/nnreal.lean Outdated Show resolved Hide resolved
src/topology/instances/nnreal.lean Outdated Show resolved Hide resolved
src/topology/instances/nnreal.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 29, 2021

✌️ kbuzzard can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added the delegated The PR author may merge after reviewing final suggestions. label Jan 29, 2021
@kbuzzard @bryangingechen
Apply suggestions from code review
a9f8fc6 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@kbuzzard
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 30, 2021
@kbuzzard
feat(topology/instances/nnreal): add has_sum_nat_add_iff and module d…
539550d 
…ocstring (#5716)
@bors
Copy link

bors bot commented Jan 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/instances/nnreal): add has_sum_nat_add_iff and module docstring [Merged by Bors] - feat(topology/instances/nnreal): add has_sum_nat_add_iff and module docstring Jan 30, 2021
@bors bors bot closed this Jan 30, 2021
@bors bors bot deleted the has_sum_nat_add_iff branch January 30, 2021 20:09
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@kbuzzard @b-mehta
feat(topology/instances/nnreal): add has_sum_nat_add_iff and module d…
ba68e27 
…ocstring (#5716)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kbuzzard @robertylewis @bryangingechen @sgouezel