Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/fintype/basic): inv of inj on deceq #5872

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat(data/fintype/basic): inv of inj on deceq #5872

wants to merge 10 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky added the awaiting-review The author would like community review of the PR label Jan 25, 2021
@pechersky pechersky mentioned this pull request Jan 25, 2021
Closed
eric-wieser
eric-wieser reviewed Jan 25, 2021
View reviewed changes
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
@pechersky
Copy link
Collaborator Author

Should these definitions and lemmas be in a different section or file?

jcommelin
jcommelin approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/data/fintype/basic.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Jan 27, 2021
pechersky and others added 2 commits January 27, 2021 10:19
@pechersky @jcommelin
Update src/data/fintype/basic.lean
06141fa 
Co-authored-by: Johan Commelin <johan@commelin.net>
@pechersky
change to namespaces
f17b782
@pechersky pechersky removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 27, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Jan 27, 2021
robertylewis
robertylewis reviewed Feb 2, 2021
View reviewed changes
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 2, 2021
eric-wieser
eric-wieser reviewed Feb 2, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to reference equiv.set.range somewhere in these docstrings, (equiv.set.range f H).symm is exactly (ignoring computability) this function.

@pechersky pechersky added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 2, 2021
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 4, 2021
bors bot pushed a commit that referenced this pull request Feb 4, 2021
@pechersky
feat(data/fintype/basic): inv of inj on deceq (#5872)
bbf9774 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@bors
Copy link

bors bot commented Feb 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/fintype/basic): inv of inj on deceq [Merged by Bors] - feat(data/fintype/basic): inv of inj on deceq Feb 4, 2021
@bors bors bot closed this Feb 4, 2021
@bors bors bot deleted the pechersky/inv-fun-dec branch February 4, 2021 21:33
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@pechersky @b-mehta
feat(data/fintype/basic): inv of inj on deceq (#5872)
3f83ec9 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@robertylewis robertylewis robertylewis left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pechersky @robertylewis @eric-wieser @jcommelin