-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(algebra/ordered_monoid): inequalities involving mul/add #6171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much all these lemmas take an h
argument only to apply either le.trans
or le.trans_lt
on it with an existing proof. I'm not sure some_long_name h ...
is really better than (some_short_name ...).trans h
, and therefore whether these lemmas are worth having,
I think in cases like this it's always worth adding the exact statement, even if it's just so it will be generated by
is significantly longer and more convoluted than
I also believe that @jcommelin is in favor of adding these lemmas -Johan, can you please confirm (or correct me if I'm wrong)? |
I'm in favour of adding lemmas like these. I don't think their existence causes any harm, and easy inequalities have such a high Lean-effort : IRL-effort ratio that any help (e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
I couldn't find some statements about inequalities, so I'm adding them. I included all the useful variants I could think of.
Pull request successfully merged into master. Build succeeded: |
I couldn't find some statements about inequalities, so I'm adding them. I included all the useful variants I could think of.
I couldn't find some statements about inequalities, so I'm adding them. I included all the useful variants I could think of.