Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topology/homeomorph): Add homeomorph_of_continuous_equiv #6295

Closed
wants to merge 5 commits into from

Conversation

callesonne
Copy link
Collaborator

Add definitions homeomorph_of_continuous_closed and homeomorph_of_continuous_equiv


@jcommelin
Copy link
Member

Thanks. Could you please add some API around these defs? This might be as easy as adding @[simps] before def.

@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 19, 2021
@callesonne
Copy link
Collaborator Author

Thanks. Could you please add some API around these defs? This might be as easy as adding @[simps] before def.

Like in the new commit? I dont get exactly what you mean by "API" in this context.

@callesonne callesonne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 20, 2021
convert ← h₂ s hs using 1,
apply e.image_eq_preimage
end,
.. e }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way (homeomorph_of_continuous_closed e h₁ h₂).to_equiv = e is a rfl:

Suggested change
.. e }
to_equiv := e }

@urkud
Copy link
Member

urkud commented Feb 21, 2021

@jcommelin @[simps] doesn't work for homeomorph because it is a new structure with h.to_fun = h.to_equiv.to_fun.
@callesonne With @[simp] attributes, simp will always unfold these definitions. If you only want to unfold them if they're applied, then you can add lemmas like @[simp] homeomorph_of_continuous_coe : ⇑(homeomorph_of_continuous e h) = e := rfl, @[simp] homeomorph_of_continuous_symm_coe : ⇑(homeomorph_of_continuous e h).symm = e.symm := rfl and @[simp] homeomorph_of_continuous_to_equiv : (homeomorph_of_continuous e h).to_equiv = e := rfl.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 22, 2021
@jcommelin
Copy link
Member

Aha, so @[simps] doesn't work. @callesonne please add lemmas like the ones that Yury suggested above.

@callesonne
Copy link
Collaborator Author

Okay, so what about homeomorph_of_continuous_closed? Comparing with homeomorph_of_continuous_open (which was there before) it has no API that I can see, should I add an API for this one as well?

@urkud
Copy link
Member

urkud commented May 12, 2022

In the meantime, an equivalent statement was merged into master. So, I'm going to close this PR.

@urkud urkud closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants