Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/group_with_zero): add lemmas about f * pi.single i x #6418

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(algebra/group_with_zero): add lemmas about f * pi.single i x #6418

wants to merge 3 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 25, 2021 •
edited

The code should be OK but @eric-wieser raised concerns about names and I agree that the names look odd. I won't need these functions in the nearest future, so I leave the decision to someone else.
Cherry-picked from #6390

@urkud urkud added the please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. label Feb 25, 2021
@urkud urkud mentioned this pull request Feb 25, 2021
Closed
@urkud
Copy link
Member Author

urkud commented Oct 28, 2022

@eric-wieser Should I close this PR?

@github-actions github-actions bot added the modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. label Apr 20, 2023
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) and removed please-adopt This PR/issue may have been abandoned by the original contributor. You are welcome to take it over. labels Apr 20, 2023
YaelDillies
YaelDillies approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the lemmas, generalised them to dependent types and renamed them. I think it's good to go.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@Vierkantor
Copy link
Collaborator

LGTM!

bors d+

@bors
Copy link

bors bot commented Apr 20, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 20, 2023
@Vierkantor
Copy link
Collaborator

Sorry!

bors d=@YaelDillies
bors r+

@bors
Copy link

bors bot commented Apr 20, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 20, 2023
bors bot pushed a commit that referenced this pull request Apr 20, 2023
@urkud @YaelDillies
feat(algebra/group_with_zero): add lemmas about f * pi.single i x (#…
246f6f7 
…6418)

Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@bors
Copy link

bors bot commented Apr 20, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/group_with_zero): add lemmas about f * pi.single i x [Merged by Bors] - feat(algebra/group_with_zero): add lemmas about f * pi.single i x Apr 20, 2023
@bors bors bot closed this Apr 20, 2023
@bors bors bot deleted the mul-single branch April 20, 2023 19:37
YaelDillies added a commit to leanprover-community/mathlib4 that referenced this pull request Apr 21, 2023
@YaelDillies
feat: Lemmas about f * pi.single i x
f2c419a 
Match leanprover-community/mathlib#6418

* [`algebra.group.pi`@`b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7`..`246f6f7989ff86bd07e1b014846f11304f33cf9e`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/pi?range=b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7..246f6f7989ff86bd07e1b014846f11304f33cf9e)
This was referenced Apr 21, 2023
Closed
Closed
bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Apr 23, 2023
@YaelDillies
feat: Function.update is monotone (#3587)
8bc7aec 
Match leanprover-community/mathlib#6418 and leanprover-community/mathlib#18841

* [`order.basic`@`210657c4ea4a4a7b234392f70a3a2a83346dfa90`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/basic?range=210657c4ea4a4a7b234392f70a3a2a83346dfa90..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`order.monotone.basic`@`ac5a7cec422c3909db52e13dde2e729657d19b0e`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/monotone/basic?range=ac5a7cec422c3909db52e13dde2e729657d19b0e..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`algebra.group.pi`@`b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/pi?range=b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
semorrison pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 10, 2023
@YaelDillies
feat: Function.update is monotone (#3587)
17d77d8 
Match leanprover-community/mathlib#6418 and leanprover-community/mathlib#18841

* [`order.basic`@`210657c4ea4a4a7b234392f70a3a2a83346dfa90`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/basic?range=210657c4ea4a4a7b234392f70a3a2a83346dfa90..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`order.monotone.basic`@`ac5a7cec422c3909db52e13dde2e729657d19b0e`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/monotone/basic?range=ac5a7cec422c3909db52e13dde2e729657d19b0e..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`algebra.group.pi`@`b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/pi?range=b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
hrmacbeth pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 10, 2023
@YaelDillies @hrmacbeth
feat: Function.update is monotone (#3587)
6bdc634 
Match leanprover-community/mathlib#6418 and leanprover-community/mathlib#18841

* [`order.basic`@`210657c4ea4a4a7b234392f70a3a2a83346dfa90`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/basic?range=210657c4ea4a4a7b234392f70a3a2a83346dfa90..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`order.monotone.basic`@`ac5a7cec422c3909db52e13dde2e729657d19b0e`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/monotone/basic?range=ac5a7cec422c3909db52e13dde2e729657d19b0e..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`algebra.group.pi`@`b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/pi?range=b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
hrmacbeth pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 11, 2023
@YaelDillies @hrmacbeth
feat: Function.update is monotone (#3587)
0ffe246 
Match leanprover-community/mathlib#6418 and leanprover-community/mathlib#18841

* [`order.basic`@`210657c4ea4a4a7b234392f70a3a2a83346dfa90`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/basic?range=210657c4ea4a4a7b234392f70a3a2a83346dfa90..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`order.monotone.basic`@`ac5a7cec422c3909db52e13dde2e729657d19b0e`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/order/monotone/basic?range=ac5a7cec422c3909db52e13dde2e729657d19b0e..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
* [`algebra.group.pi`@`b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7`..`90df25ded755a2cf9651ea850d1abe429b1e4eb1`](https://leanprover-community.github.io/mathlib-port-status/file/algebra/group/pi?range=b3f25363ae62cb169e72cd6b8b1ac97bacf21ca7..90df25ded755a2cf9651ea850d1abe429b1e4eb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. modifies-synchronized-file This PR touches a files that has already been ported to mathlib4, and may need a synchronization PR. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @Vierkantor @YaelDillies