Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data/list/defs): remove chunking hack #6441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gebner
Copy link
Member

@gebner gebner commented Feb 26, 2021

Before Lean 3.27, it was impossible to spawn more than a few thousand tasks via task.delay, because storing the log messages was quadratic in the number of tasks.


@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Feb 27, 2021
@semorrison
Copy link
Collaborator

The linter ran forever, possibly indicating there is still a problem with the unchunked async. I just restarted it now, in case it was a one-off.

@YaelDillies
Copy link
Collaborator

What's the status here? Is this still needed?

@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
@eric-wieser eric-wieser requested a review from a team as a code owner October 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants