-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(ring_theory/valuation): valuations in linear_ordered_comm_monoid_with_zero
#6500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming most of the lemmas have just moved, this looks fine to me
I haven't changed anything except the instance assumptions and the organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few docstring cleanup suggestions while we're at it. Otherwise LGTM.
bors d+
✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
bors r+ |
…onoid_with_zero` (#6500) Generalizes the value group in a `valuation` to a `linear_ordered_comm_monoid_with_zero` Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
linear_ordered_comm_monoid_with_zero
linear_ordered_comm_monoid_with_zero
…onoid_with_zero` (#6500) Generalizes the value group in a `valuation` to a `linear_ordered_comm_monoid_with_zero` Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Generalizes the value group in a
valuation
to alinear_ordered_comm_monoid_with_zero