[Merged by Bors] - chore(algebra/ring/basic): weaken ring.inverse to only require monoid_with_zero #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
sgouezel
reviewed
Mar 9, 2021
| @@ -892,24 +892,24 @@ lemma add_monoid_hom.coe_add_monoid_hom_mk_ring_hom_of_mul_self_of_two_ne_zero [ | |||
| end integral_domain | |||
|
|
|||
| namespace ring | |||
There was a problem hiding this comment.
Do you really want to keep this in the ring namespace?
There was a problem hiding this comment.
I have no idea where this belongs. monoid_with_zero.inverse is significantly longer. My thinking was that if no one has any particularly compelling name ideas, we may as well leave it where it is.
Leaving the name unchanged also saves me from having to change every caller!
There was a problem hiding this comment.
I'm fine with this, but then should mention it explicitly in the docstring.
eric-wieser
commented
Mar 9, 2021
|
bors r+ |
github-actions
bot
added
ready-to-merge
|
Build failed (retrying...): |
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #5539 because I actually want to use this, and the PR is large and stalled.