Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix (topology/algebra/basic): fix universe issue with of_nhds_one #6647

Closed
wants to merge 1 commit into from

Conversation

kbuzzard
Copy link
Member

@kbuzzard kbuzzard commented Mar 11, 2021

Everything had type max{u v} before.


Right now on master we have this:

import topology.algebra.group

set_option pp.universes true
/-
topological_group.of_nhds_one.{u_1 u_2} :
  ∀ {G : Type (max u_1 u_2)} [_inst_5 : group.{(max u_1 u_2)} G] [_inst_6 : topological_space.{(max u_1 u_2)} G],
    filter.tendsto.{(max u_1 u_2) (max u_1 u_2)}
      (function.uncurry.{(max u_1 u_2) (max u_1 u_2) (max u_1 u_2)} has_mul.mul.{(max u_1 u_2)})
      ((nhds.{(max u_1 u_2)} 1).prod (nhds.{(max u_1 u_2)} 1))
      (nhds.{(max u_1 u_2)} 1) →
    filter.tendsto.{(max u_1 u_2) (max u_1 u_2)} (λ (x : G), x⁻¹) (nhds.{(max u_1 u_2)} 1)
      (nhds.{(max u_1 u_2)} 1) →
    (∀ (x₀ : G),
       nhds.{(max u_1 u_2)} x₀ =
         filter.map.{(max u_1 u_2) (max u_1 u_2)} (λ (x : G), x₀ * x) (nhds.{(max u_1 u_2)} 1)) →
    (∀ (x₀ : G),
       filter.tendsto.{(max u_1 u_2) (max u_1 u_2)} (λ (x : G), x₀ * x * x₀⁻¹) (nhds.{(max u_1 u_2)} 1)
         (nhds.{(max u_1 u_2)} 1)) →
    topological_group.{(max u_1 u_2)} G
All Messages (1)

-/

These caused a rewrite to fail! This fix to topology.algebra.group fixes the universe problem and enables the rewrite to work. Is this related to this discussion? https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/universe.20issue.20with.20.60Type*.60/near/228074514

Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

bors bot pushed a commit that referenced this pull request Mar 11, 2021
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 11, 2021
@bors
Copy link

bors bot commented Mar 12, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix (topology/algebra/basic): fix universe issue with of_nhds_one [Merged by Bors] - fix (topology/algebra/basic): fix universe issue with of_nhds_one Mar 12, 2021
@bors bors bot closed this Mar 12, 2021
@bors bors bot deleted the of_nhds_one branch March 12, 2021 00:17
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants