[Merged by Bors] - refactor(ring_theory/discrete_valuation_ring): discrete_valuation_ring.add_val as an add_valuation
#6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awainverse
added
the
awaiting-review
eric-wieser
reviewed
Mar 12, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2021
…ng.add_val` as an `add_valuation` (#6660) Refactors `discrete_valuation_ring.add_val` to be an `enat`-valued `add_valuation`. Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2021
…ng.add_val` as an `add_valuation` (#6660) Refactors `discrete_valuation_ring.add_val` to be an `enat`-valued `add_valuation`. Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
discrete_valuation_ring.add_val as an add_valuationdiscrete_valuation_ring.add_val as an add_valuation
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…ng.add_val` as an `add_valuation` (#6660) Refactors `discrete_valuation_ring.add_val` to be an `enat`-valued `add_valuation`. Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
discrete_valuation_ring.add_valto be anenat-valuedadd_valuation.