Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/polynomial/homogenous): add a direct_sum.gcomm_monoid instance #6825

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 23, 2021

This also corrects a stupid typo I made in direct_sum.comm_ring which was previously declared a ring!


Open in Gitpod

I started out on trying to show:

/-- `homogeneous_component` but better? -/
def homogeneous_component' [comm_semiring R] (n : ℕ) :
  mv_polynomial σ R →ₗ[R] homogeneous_submodule σ R n :=
let f := finsupp.restrict_dom R R {d : σ →₀ ℕ | ∑ i in d.support, d i = n} in
(submodule.of_le $ (homogenous_submodule_eq_finsupp_supported _ _ _).symm.le).comp f

-- the real goal would be to make this an alg_hom, but baby steps!
def homogeneous_components [comm_semiring R] (n : ℕ) :
  mv_polynomial σ R →+* (⨁ i, homogeneous_submodule σ R i) :=
add_monoid_algebra.lift_nc_ring_hom
  { to_fun := λ r, r • 1,  -- this is basically `algebra_map`, which doesn't exist yet.
    map_one' := by { ext, simp, },
    map_mul' := λ x y, by { ext, simp, sorry },
    map_zero' := zero_smul _ _,
    map_add' := λ x y, add_smul _ _ _,}
  sorry
  sorry

but I think there's some API missing around direct_sum before that becomes easy, so want to punt it to future work, possibly for someone else.

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Mar 23, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 23, 2021
bors bot pushed a commit that referenced this pull request Mar 23, 2021
…id` instance (#6825)

This also corrects a stupid typo I made in `direct_sum.comm_ring` which was previously declared a `ring`!
@bors
Copy link

bors bot commented Mar 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/polynomial/homogenous): add a direct_sum.gcomm_monoid instance [Merged by Bors] - feat(ring_theory/polynomial/homogenous): add a direct_sum.gcomm_monoid instance Mar 23, 2021
@bors bors bot closed this Mar 23, 2021
@bors bors bot deleted the eric-wieser/homogenous-direct_sum branch March 23, 2021 07:48
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…id` instance (#6825)

This also corrects a stupid typo I made in `direct_sum.comm_ring` which was previously declared a `ring`!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants