Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category): structured arrows #6830

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat(category): structured arrows #6830

wants to merge 10 commits into from

Conversation

semorrison
Copy link
Collaborator

Factored out from #6820.

Open in Gitpod

@semorrison semorrison mentioned this pull request Mar 23, 2021
Closed
1 task
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Mar 23, 2021
b-mehta
b-mehta approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

src/category_theory/structured_arrow.lean Outdated Show resolved Hide resolved
@adamtopaz
Copy link
Collaborator

LGTM! I added this as a dependency in #6820 and I'll get rid of the Ran/Lan.index once this gets merged.

@semorrison @b-mehta
Update src/category_theory/structured_arrow.lean
d1a22a9 
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 24, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 24, 2021
jcommelin
jcommelin approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 29, 2021
bors bot pushed a commit that referenced this pull request Mar 29, 2021
@semorrison
feat(category): structured arrows (#6830)
66ee65c 
Factored out from #6820.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Mar 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category): structured arrows [Merged by Bors] - feat(category): structured arrows Mar 29, 2021
@bors bors bot closed this Mar 29, 2021
@bors bors bot deleted the structured_arrow branch March 29, 2021 17:50
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@semorrison @b-mehta
feat(category): structured arrows (#6830)
bb3fe66 
Factored out from #6820.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@b-mehta b-mehta b-mehta approved these changes

@adamtopaz adamtopaz Awaiting requested review from adamtopaz

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @adamtopaz @jcommelin @b-mehta