Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/lifting_properties): create a new file about lifting properties #6852

Closed
wants to merge 26 commits into from

Conversation

JakobScholbach
Copy link
Collaborator

@JakobScholbach JakobScholbach commented Mar 24, 2021

This file introduces lifting properties, establishes a few basic properties, and constructs a subcategory spanned by morphisms having a right lifting property.


Open in Gitpod

@JakobScholbach JakobScholbach added the awaiting-review The author would like community review of the PR label Mar 24, 2021
@jcommelin jcommelin changed the title create a new file about lifting properties feat(category_theory/lifting_properties): create a new file about lifting properties Mar 24, 2021
@semorrison
Copy link
Collaborator

I wonder if we should just add

instance {X Y : T} : has_coe (X ⟶ Y) (arrow T) := ⟨mk⟩

back in category_theory.arrow.

src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 24, 2021
@JakobScholbach
Copy link
Collaborator Author

I wonder if we should just add

instance {X Y : T} : has_coe (X ⟶ Y) (arrow T) := ⟨mk⟩

back in category_theory.arrow.

I am very new to all these of optimisation thoughts, so I am certainly the wrong person to ask.

@TwoFX
Copy link
Member

TwoFX commented Mar 30, 2021

Given that both has_lift and strong_epi (which is in many ways similar to has_lifting_property) are classes, I think that there's a case to be made for also making has_lifting_property a class and providing an instance [has_lifting_property i p] (sq : i ⟶ p) : has_lift sq. This would also make working with lifting properties more smooth because you don't have to write haveI := ... for every lift that you want to take.

@semorrison, @JakobScholbach, what do you think?

@JakobScholbach
Copy link
Collaborator Author

Given that both has_lift and strong_epi (which is in many ways similar to has_lifting_property) are classes, I think that there's a case to be made for also making has_lifting_property a class and providing an instance [has_lifting_property i p] (sq : i ⟶ p) : has_lift sq. This would also make working with lifting properties more smooth because you don't have to write haveI := ... for every lift that you want to take.

@semorrison, @JakobScholbach, what do you think?

I have tried my hand with this. This does nicely simplify has_right_lifting_property_comp. I also feel that some turns in the proof of right_lifting_property_initial_iff should be unnecessary, but I don't quite see how.

@TwoFX TwoFX added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 31, 2021
src/category_theory/arrow.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Looking good! Thanks a lot

src/category_theory/arrow.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
src/category_theory/lifting_properties.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 31, 2021
bors bot pushed a commit that referenced this pull request Mar 31, 2021
…ting properties (#6852)

This file introduces lifting properties, establishes a few basic properties, and constructs a subcategory spanned by morphisms having a right lifting property.
@bors
Copy link

bors bot commented Mar 31, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/lifting_properties): create a new file about lifting properties [Merged by Bors] - feat(category_theory/lifting_properties): create a new file about lifting properties Mar 31, 2021
@bors bors bot closed this Mar 31, 2021
@bors bors bot deleted the lifting_properties branch March 31, 2021 14:32
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…ting properties (#6852)

This file introduces lifting properties, establishes a few basic properties, and constructs a subcategory spanned by morphisms having a right lifting property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants