Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/log): add some lemmas and monotonicity #6899

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(data/nat/log): add some lemmas and monotonicity #6899

wants to merge 7 commits into from

Conversation

hallow-world
Copy link
Collaborator

Open in Gitpod

@hallow-world hallow-world added the awaiting-review The author would like community review of the PR label Mar 26, 2021
Ruben-VandeVelde
Ruben-VandeVelde reviewed Mar 26, 2021
View reviewed changes
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpicking below:

src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
src/data/nat/log.lean Outdated Show resolved Hide resolved
semorrison
semorrison reviewed Mar 27, 2021
View reviewed changes
src/data/nat/log.lean Outdated Show resolved Hide resolved
semorrison
semorrison reviewed Mar 27, 2021
View reviewed changes
src/data/nat/log.lean Outdated Show resolved Hide resolved
semorrison
semorrison reviewed Mar 27, 2021
View reviewed changes
src/data/nat/log.lean Outdated Show resolved Hide resolved
semorrison
semorrison reviewed Mar 27, 2021
View reviewed changes
src/data/nat/log.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 27, 2021
@hallow-world hallow-world added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 27, 2021
semorrison
semorrison approved these changes Mar 27, 2021
View reviewed changes
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hallow-world hallow-world mentioned this pull request Mar 27, 2021
Closed
1 task
bryangingechen
bryangingechen approved these changes Mar 27, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 27, 2021
bors bot pushed a commit that referenced this pull request Mar 27, 2021
@hallow-world
feat(data/nat/log): add some lemmas and monotonicity (#6899)
d32f9c7
@bors
Copy link

bors bot commented Mar 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/log): add some lemmas and monotonicity [Merged by Bors] - feat(data/nat/log): add some lemmas and monotonicity Mar 27, 2021
@bors bors bot closed this Mar 27, 2021
@bors bors bot deleted the experimental branch March 27, 2021 08:28
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@hallow-world @b-mehta
feat(data/nat/log): add some lemmas and monotonicity (#6899)
fb1ccb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde left review comments

@semorrison semorrison semorrison approved these changes

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hallow-world @semorrison @bryangingechen @Ruben-VandeVelde