Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/perm/sign): the alternating group #6913

Closed
wants to merge 15 commits into from

Conversation

awainverse
Copy link
Collaborator

Defines alternating_subgroup to be sign.ker
Proves a few basic lemmas about its cardinality


Open in Gitpod

@awainverse awainverse added the awaiting-review The author would like community review of the PR label Mar 27, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, thanks.

My only question would be whether we want to put this in its own file, perhaps group_theory/alternating, to make it easier to find.

@awainverse
Copy link
Collaborator Author

It would make more sense to me to split the sign.lean file into multiple files, because I think the support of a permutation, or the definition of disjoint permutations, has less to do with the sign homomorphism than the alternating group does. However, I realize most of the facts I want to show about the alternating group will actually land in the is_cycle file, so maybe it could make sense to split it off...

@eric-wieser
Copy link
Member

bors d+

I pushed a golf of the card = 1 proof, along with the unique instance needed to prove it. Let's leave moving it to a new file for another time.

@bors
Copy link

bors bot commented Apr 2, 2021

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@awainverse
Copy link
Collaborator Author

I've added one more small lemma, prod_list_swap_mem_alternating_subgroup_iff_even_length. Am I still good to merge this once CI builds, @eric-wieser ?

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser
Copy link
Member

bors d+ (again)

Let's wait for CI

@bors
Copy link

bors bot commented Apr 3, 2021

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@awainverse
Copy link
Collaborator Author

Thanks!

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 3, 2021
@awainverse
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 3, 2021
Defines `alternating_subgroup` to be `sign.ker`
Proves a few basic lemmas about its cardinality



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
@bors
Copy link

bors bot commented Apr 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/perm/sign): the alternating group [Merged by Bors] - feat(group_theory/perm/sign): the alternating group Apr 4, 2021
@bors bors bot closed this Apr 4, 2021
@bors bors bot deleted the alternating_subgroup branch April 4, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants