New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(group_theory/perm/sign): the alternating group #6913
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thanks.
My only question would be whether we want to put this in its own file, perhaps group_theory/alternating
, to make it easier to find.
It would make more sense to me to split the |
bors d+ I pushed a golf of the |
✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with |
I've added one more small lemma, |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bors d+ (again) Let's wait for CI |
✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks! |
bors r+ |
Defines `alternating_subgroup` to be `sign.ker` Proves a few basic lemmas about its cardinality Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
Defines
alternating_subgroup
to besign.ker
Proves a few basic lemmas about its cardinality