Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(group_theory/group_action/defs): combine duplicated comp_hom and rename derivative definitions #6942

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore(group_theory/group_action/defs): combine duplicated comp_hom and rename derivative definitions #6942

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 29, 2021 •
edited
Loading

Zulip thread

Open in Gitpod

This encompasses #6909.

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Mar 29, 2021
@eric-wieser
Merge branch 'eric-wieser/smul_zero_class.comp' into eric-wieser/mul_…
10d50aa 
…action.comp_hom

# Conflicts:
#	src/algebra/module/basic.lean
@eric-wieser
fix
582d02a
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 29, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 29, 2021
Vierkantor
Vierkantor approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Zulip thread has died down with this as the consensus opinion, so I'm merging it. Thanks 🎉

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 30, 2021
@eric-wieser eric-wieser mentioned this pull request Mar 30, 2021
Closed
bors bot pushed a commit that referenced this pull request Mar 30, 2021
@eric-wieser
chore(group_theory/group_action/defs): combine duplicated comp_hom …
ed6d94a 
…and rename derivative definitions (#6942)

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Duplicate.20mul_action.20defs/near/232246589)
@bors
Copy link

bors bot commented Mar 30, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/group_action/defs): combine duplicated comp_hom and rename derivative definitions [Merged by Bors] - chore(group_theory/group_action/defs): combine duplicated comp_hom and rename derivative definitions Mar 30, 2021
@bors bors bot closed this Mar 30, 2021
@bors bors bot deleted the eric-wieser/mul_action.comp_hom branch March 30, 2021 17:12
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@eric-wieser @b-mehta
chore(group_theory/group_action/defs): combine duplicated comp_hom …
edfbee4 
…and rename derivative definitions (#6942)

[Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Duplicate.20mul_action.20defs/near/232246589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@urkud urkud Awaiting requested review from urkud

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @Vierkantor