Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tactic/noncomm_ring): expand out powers using pow_succ #6990

Closed
wants to merge 1 commit into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Apr 1, 2021

Somehow, a previous commit broke noncomm_ring. This PR adds some more pow_succ power to it to revive it.


Open in Gitpod

Zulip discussion: https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/noncomm_ring.20regression

@pechersky
Copy link
Collaborator Author

Mario Carneiro: I'm not a fan of heuristic extensions to tactics with a well defined scope
Mario Carneiro: a ^ b.succ is not a ring expression
Mario Carneiro: it sounds like you want noncomm_ring_exp

Closing due to feature creep.

@pechersky pechersky closed this Apr 1, 2021
@pechersky pechersky deleted the pechersky/noncomm-ring-pow-succ branch November 29, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant